From 94379347dfd0c83e3c0355d9deeaba419d50edb3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sa=C5=A1a=20=C4=8Cavara?= <sasa.cavara@reversinglabs.com>
Date: Sun, 20 Nov 2022 11:43:35 +0100
Subject: [PATCH 1/4] add systemctl device type configuration option

---
 scrutiny_fa/config.json                       |  2 ++
 .../etc/cont-init.d/01-configuration.sh       | 26 +++++++++++++++++++
 2 files changed, 28 insertions(+)

diff --git a/scrutiny_fa/config.json b/scrutiny_fa/config.json
index 78f445339..13b322ca7 100644
--- a/scrutiny_fa/config.json
+++ b/scrutiny_fa/config.json
@@ -39,6 +39,8 @@
     "Mode": "list(Collector+WebUI|Collector)?",
     "TZ": "str?",
     "Updates": "list(Hourly|Daily|Weekly)"
+    "SMARTCTL_COMMAND_DEVICE_TYPE": "list(auto|ata|scsi|sat|usbcypress|usbjmicron|usbsunplus|marvell|megaraid)?",
+    "SMARTCTL_MEGARAID_DISK_NUM":"int?"
   },
   "slug": "scrutiny_fa",
   "udev": true,
diff --git a/scrutiny_fa/rootfs/etc/cont-init.d/01-configuration.sh b/scrutiny_fa/rootfs/etc/cont-init.d/01-configuration.sh
index e4a1a685b..64de19ca8 100644
--- a/scrutiny_fa/rootfs/etc/cont-init.d/01-configuration.sh
+++ b/scrutiny_fa/rootfs/etc/cont-init.d/01-configuration.sh
@@ -62,3 +62,29 @@ case "$FREQUENCY" in
         sed -i "1a export COLLECTOR_CRON_SCHEDULE=\"0 0 * * 0\"" /etc/cont-init.d/50-cron-config
         ;;
 esac
+############################
+# SMARTCTL COMMAND OPTIONS #
+############################
+
+# Alignt with smartctl commands options
+if bashio::config.has_value "SMARTCTL_COMMAND_DEVICE_TYPE"; then
+    device_type="$(bashio::config 'SMARTCTL_COMMAND_DEVICE_TYPE')"
+    if ! bashio::config.has_value "SMARTCTL_MEGARAID_DISK_NUM"; then
+        megaraid_disk_num="$(bashio::config 'SMARTCTL_MEGARAID_DISK_NUM')"
+        {
+        echo "commands:"
+        echo "  metrics_smartctl_bin: '/usr/sbin/smartctl'"
+        echo "  metrics_scan_args: '--scan --json --dev ${device_type}'"
+        echo "  metrics_info_args: '--info --json --dev ${device_type}'"
+        echo "  metrics_smart_args: '--xall --json --dev ${device_type}'"
+        } > /opt/scrutiny/config/collector.yaml
+    else
+        {
+        echo "commands:"
+        echo "  metrics_smartctl_bin: '/usr/sbin/smartctl'"
+        echo "  metrics_scan_args: '--scan --json --dev ${device_type},${megaraid_disk_num}'"
+        echo "  metrics_info_args: '--info --json --dev ${device_type},${megaraid_disk_num}'"
+        echo "  metrics_smart_args: '--xall --json --dev ${device_type},${megaraid_disk_num}'"
+        } > /opt/scrutiny/config/collector.yaml
+    fi
+fi

From 5ada5215e258469ae7dbfda9b621d721a242f143 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sa=C5=A1a=20=C4=8Cavara?= <sasa.cavara@reversinglabs.com>
Date: Sun, 20 Nov 2022 13:57:22 +0100
Subject: [PATCH 2/4] add systemctl device type configuration option - fix
 missing comma

---
 scrutiny_fa/config.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scrutiny_fa/config.json b/scrutiny_fa/config.json
index 13b322ca7..7254291da 100644
--- a/scrutiny_fa/config.json
+++ b/scrutiny_fa/config.json
@@ -38,7 +38,7 @@
     "COLLECTOR_API_ENDPOINT": "str?",
     "Mode": "list(Collector+WebUI|Collector)?",
     "TZ": "str?",
-    "Updates": "list(Hourly|Daily|Weekly)"
+    "Updates": "list(Hourly|Daily|Weekly)",
     "SMARTCTL_COMMAND_DEVICE_TYPE": "list(auto|ata|scsi|sat|usbcypress|usbjmicron|usbsunplus|marvell|megaraid)?",
     "SMARTCTL_MEGARAID_DISK_NUM":"int?"
   },

From cae446ca9dc3c93d3c503152586a6dae34c2c522 Mon Sep 17 00:00:00 2001
From: Alexandre <44178713+alexbelgium@users.noreply.github.com>
Date: Sun, 20 Nov 2022 14:18:22 +0100
Subject: [PATCH 3/4] New version

---
 scrutiny_fa/config.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scrutiny_fa/config.json b/scrutiny_fa/config.json
index 7254291da..439e014a5 100644
--- a/scrutiny_fa/config.json
+++ b/scrutiny_fa/config.json
@@ -45,5 +45,5 @@
   "slug": "scrutiny_fa",
   "udev": true,
   "url": "https://github.com/AnalogJ/scrutiny",
-  "version": "v0.5.0-4"
+  "version": "v0.5.0-5"
 }

From 1d3788901eaaf8781ac059d0c0a1e682f0681e16 Mon Sep 17 00:00:00 2001
From: Alexandre <44178713+alexbelgium@users.noreply.github.com>
Date: Sun, 20 Nov 2022 14:25:27 +0100
Subject: [PATCH 4/4] Update CHANGELOG.md

---
 scrutiny_fa/CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scrutiny_fa/CHANGELOG.md b/scrutiny_fa/CHANGELOG.md
index 800f95ac4..7b0ad7af9 100644
--- a/scrutiny_fa/CHANGELOG.md
+++ b/scrutiny_fa/CHANGELOG.md
@@ -1,3 +1,4 @@
+- New options SMARTCTL_COMMAND_DEVICE_TYPE & SMARTCTL_MEGARAID_DISK_NUM (@scavara)
 - New option "Mode" : Collector+WebUI or Collector only
 
 ## v0.5.0 (26-08-2022)