avm/hassio-addons
1
0
Fork 0
mirror of https://github.com/alexbelgium/hassio-addons.git synced 2026-06-13 11:01:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix build workflow: add fail-fast, BUILD_DATE, cache-gha-scope, persist-credentials

Browse Source 
Reviewed against official home-assistant/apps-example commit b09b6e5d:

- Add fail-fast: false to prevent cascade cancellation of matrix builds
- Add BUILD_DATE build arg (117 Dockerfiles reference ARG BUILD_DATE)
- Add cache-gha-scope per addon to prevent cache collisions
- Add persist-credentials: false on checkout (security best practice)

Co-authored-by: alexbelgium <44178713+alexbelgium@users.noreply.github.com>
Agent-Logs-Url: https://github.com/alexbelgium/hassio-addons/sessions/fc2bf147-8d75-4c87-84be-7a093db2780a
This commit is contained in:
copilot-swe-agent[bot]
2026-03-26 06:29:44 +00:00
parent bd5d83de21
commit 1939c7bbb4
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/onpush_builder.yaml vendored
View File

@@ -115,6 +115,7 @@ jobs:
contents: read contents: read
packages: write packages: write
strategy: strategy:
fail-fast: false
matrix: matrix:
addon: ${{ fromJSON(needs.detect-changed-addons.outputs.changedAddons) }} addon: ${{ fromJSON(needs.detect-changed-addons.outputs.changedAddons) }}
arch: ["aarch64", "amd64"] arch: ["aarch64", "amd64"]
@@ -125,6 +126,8 @@ jobs:
runner: ubuntu-24.04-arm runner: ubuntu-24.04-arm
steps: steps:
- uses: actions/checkout@v6 - uses: actions/checkout@v6
with:
persist-credentials: false
- name: Resolve Symlinks (in repo) - name: Resolve Symlinks (in repo)
run: | run: |
find . -type l | while read -r link; do find . -type l | while read -r link; do
@@ -199,6 +202,7 @@ jobs:
echo "description=$description" >> "$GITHUB_OUTPUT" echo "description=$description" >> "$GITHUB_OUTPUT"
echo "architectures=$arch_list" >> "$GITHUB_OUTPUT" echo "architectures=$arch_list" >> "$GITHUB_OUTPUT"
echo "build_from=$build_from" >> "$GITHUB_OUTPUT" echo "build_from=$build_from" >> "$GITHUB_OUTPUT"
echo "build_date=$(date --rfc-3339=seconds --utc)" >> "$GITHUB_OUTPUT"
echo "Addon: $ADDON, Arch: $ARCH" echo "Addon: $ADDON, Arch: $ARCH"
echo " Version: $version" echo " Version: $version"
@@ -228,6 +232,7 @@ jobs:
uses: home-assistant/builder/actions/build-image@2026.03.2 uses: home-assistant/builder/actions/build-image@2026.03.2
with: with:
arch: ${{ matrix.arch }} arch: ${{ matrix.arch }}
cache-gha-scope: ${{ matrix.addon }}
context: "./${{ matrix.addon }}" context: "./${{ matrix.addon }}"
image: ${{ steps.info.outputs.image }} image: ${{ steps.info.outputs.image }}
image-tags: | image-tags: |
@@ -239,6 +244,7 @@ jobs:
container-registry-password: ${{ secrets.GITHUB_TOKEN }} container-registry-password: ${{ secrets.GITHUB_TOKEN }}
build-args: | build-args: |
BUILD_FROM=${{ steps.info.outputs.build_from }} BUILD_FROM=${{ steps.info.outputs.build_from }}
BUILD_DATE=${{ steps.info.outputs.build_date }}
BUILD_DESCRIPTION=${{ steps.info.outputs.description }} BUILD_DESCRIPTION=${{ steps.info.outputs.description }}
BUILD_NAME=${{ steps.info.outputs.name }} BUILD_NAME=${{ steps.info.outputs.name }}
BUILD_REF=${{ github.sha }} BUILD_REF=${{ github.sha }}