avm/hassio-addons
1
0
Fork 0
mirror of https://github.com/alexbelgium/hassio-addons.git synced 2026-05-27 10:54:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix corrupted HEALTH_URL and ASCII art in Dockerfiles caused by version updater

Browse Source 
The addons_updater script's global sed replacement corrupted Dockerfiles
when the upstream_version was empty (""), replacing all empty double-quoted
strings with version strings. This corrupted:

- HEALTH_URL values (causing malformed health check URLs and container
  instability from failed health checks)
- ASCII art comments in Dockerfile headers

Fixed affected addons: guacamole, tdarr, photoprism, enedisgateway2mqtt_dev,
gazpar2mqtt, seafile

Also added a guard in the updater script to skip updates when version
strings are empty, preventing this corruption from recurring.

Co-authored-by: alexbelgium <44178713+alexbelgium@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-26 17:15:13 +00:00
parent b217fbaf91
commit 26d29f101d
7 changed files with 22 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
addons_updater/rootfs/etc/cont-init.d/99-run.sh
View File

@@ -319,6 +319,12 @@ for f in */; do
LASTVERSION2=${LASTVERSION//+/-} LASTVERSION2=${LASTVERSION//+/-}
CURRENT2=${CURRENT//+/-} CURRENT2=${CURRENT//+/-}
# Skip if current or last version is empty (would corrupt files by replacing all "" occurrences)
if [ "${CURRENT}" = '""' ] || [ "${LASTVERSION}" = '""' ]; then
bashio::log.warning "... $SLUG : skipping update due to empty version string (current=${CURRENT}, latest=${LASTVERSION})"
continue
fi
# Update if needed # Update if needed
if [ "${CURRENT2}" != "${LASTVERSION2}" ]; then if [ "${CURRENT2}" != "${LASTVERSION2}" ]; then
LOGINFO="... $SLUG : update from ${CURRENT} to ${LASTVERSION}" && if [ "$VERBOSE" = true ]; then bashio::log.info "$LOGINFO"; fi LOGINFO="... $SLUG : update from ${CURRENT} to ${LASTVERSION}" && if [ "$VERBOSE" = true ]; then bashio::log.info "$LOGINFO"; fi

4
enedisgateway2mqtt_dev/Dockerfile
View File

@@ -2,11 +2,11 @@
# ALEXBELGIUM'S DOCKERFILE # # ALEXBELGIUM'S DOCKERFILE #
#============================# #============================#
# _.------. # _.------.
# _.-` ('>.-`"0.8.13""-. # _.-` ('>.-`"""-.
# '.--'` _'` _ .--.) # '.--'` _'` _ .--.)
# -' '-.-';` ` # -' '-.-';` `
# ' - _.' ``'--. # ' - _.' ``'--.
# '---` .-'"0.8.13"` # '---` .-'""`
# /` # /`
#=== Home Assistant Addon ===# #=== Home Assistant Addon ===#

4
gazpar2mqtt/Dockerfile
View File

@@ -2,11 +2,11 @@
# ALEXBELGIUM'S DOCKERFILE # # ALEXBELGIUM'S DOCKERFILE #
#============================# #============================#
# _.------. # _.------.
# _.-` ('>.-`"0.8.2""-. # _.-` ('>.-`"""-.
# '.--'` _'` _ .--.) # '.--'` _'` _ .--.)
# -' '-.-';` ` # -' '-.-';` `
# ' - _.' ``'--. # ' - _.' ``'--.
# '---` .-'"0.8.2"` # '---` .-'""`
# /` # /`
#=== Home Assistant Addon ===# #=== Home Assistant Addon ===#

6
guacamole/Dockerfile
View File

@@ -2,11 +2,11 @@
# ALEXBELGIUM'S DOCKERFILE # # ALEXBELGIUM'S DOCKERFILE #
#============================# #============================#
# _.------. # _.------.
# _.-` ('>.-`"1.6.0-bullseye""-. # _.-` ('>.-`"""-.
# '.--'` _'` _ .--.) # '.--'` _'` _ .--.)
# -' '-.-';` ` # -' '-.-';` `
# ' - _.' ``'--. # ' - _.' ``'--.
# '---` .-'"1.6.0-bullseye"` # '---` .-'""`
# /` # /`
#=== Home Assistant Addon ===# #=== Home Assistant Addon ===#
@@ -134,7 +134,7 @@ LABEL \
################# #################
ENV HEALTH_PORT="8080" \ ENV HEALTH_PORT="8080" \
HEALTH_URL="1.6.0-bullseye" HEALTH_URL=""
HEALTHCHECK \ HEALTHCHECK \
--interval=5s \ --interval=5s \
--retries=5 \ --retries=5 \

8
photoprism/Dockerfile
View File

@@ -2,11 +2,11 @@
# ALEXBELGIUM'S DOCKERFILE # # ALEXBELGIUM'S DOCKERFILE #
#============================# #============================#
# _.------. # _.------.
# _.-` ('>.-`"ubuntu-2025-11-30""-. # _.-` ('>.-`"""-.
# '.--'` _'` _ .--.) # '.--'` _'` _ .--.)
# -' '-.-';` ` # -' '-.-';` `
# ' - _.' ``'--. # ' - _.' ``'--.
# '---` .-'"ubuntu-2025-11-30"` # '---` .-'""`
# /` # /`
#=== Home Assistant Addon ===# #=== Home Assistant Addon ===#
@@ -134,8 +134,8 @@ RUN \
mv /etc/nginx/nginx.conf.new /etc/nginx/nginx.conf; \ mv /etc/nginx/nginx.conf.new /etc/nginx/nginx.conf; \
fi fi
ENV HEALTH_PORT="ubuntu-2025-11-30" \ ENV HEALTH_PORT="2341" \
HEALTH_URL="ubuntu-2025-11-30" HEALTH_URL=""
HEALTHCHECK \ HEALTHCHECK \
--interval=5m \ --interval=5m \
--retries=5 \ --retries=5 \

4
seafile/Dockerfile
View File

@@ -2,11 +2,11 @@
# ALEXBELGIUM'S DOCKERFILE # # ALEXBELGIUM'S DOCKERFILE #
#============================# #============================#
# _.------. # _.------.
# _.-` ('>.-`"12.0.14""-. # _.-` ('>.-`"""-.
# '.--'` _'` _ .--.) # '.--'` _'` _ .--.)
# -' '-.-';` ` # -' '-.-';` `
# ' - _.' ``'--. # ' - _.' ``'--.
# '---` .-'"12.0.14"` # '---` .-'""`
# /` # /`
#=== Home Assistant Addon ===# #=== Home Assistant Addon ===#

6
tdarr/Dockerfile
View File

@@ -2,11 +2,11 @@
# ALEXBELGIUM'S DOCKERFILE # # ALEXBELGIUM'S DOCKERFILE #
#============================# #============================#
# _.------. # _.------.
# _.-` ('>.-`"2.58.02""-. # _.-` ('>.-`"""-.
# '.--'` _'` _ .--.) # '.--'` _'` _ .--.)
# -' '-.-';` ` # -' '-.-';` `
# ' - _.' ``'--. # ' - _.' ``'--.
# '---` .-'"2.58.02"` # '---` .-'""`
# /` # /`
#=== Home Assistant Addon ===# #=== Home Assistant Addon ===#
@@ -119,7 +119,7 @@ RUN \
fi fi
ENV HEALTH_PORT="8265" \ ENV HEALTH_PORT="8265" \
HEALTH_URL="2.58.02" HEALTH_URL=""
HEALTHCHECK \ HEALTHCHECK \
--interval=5s \ --interval=5s \
--retries=5 \ --retries=5 \