avm/hassio-addons
1
0
Fork 0
mirror of https://github.com/alexbelgium/hassio-addons.git synced 2026-10-04 07:21:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(fireflyiii_fints_importer): stop the configurations folder nesting inside itself

Browse Source 
/data persists across restarts, so from the second boot on
`ln -sf $CONFIGSOURCE /data/configurations` dereferenced the existing
link and created $CONFIGSOURCE/fireflyiii_fints_importer -> itself. The
app then listed that entry as a configuration and file_get_contents()
failed on it (#3091).

Use ln -sfn, remove the leftover self-link, and drop the dead copy
blocks (they tested -f on directories) and the /app/configurations
link, which made the app list every configuration twice.

Fixes #3091

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
alexbelgium
2026-09-28 07:31:40 +02:00
parent 20254f1eaf
commit 43c07e91e4
3 changed files with 10 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
fireflyiii_fints_importer/CHANGELOG.md
View File

@@ -1,3 +1,7 @@
## 1.3.0.8 (28-09-2026)
- Fix the configurations folder nesting inside itself on every restart, which made the web UI show `ConfigurationFactory.php` errors (#3091). The leftover self-referencing link is removed at startup, and the configurations are now linked only once, at `data/configurations`.
## 1.3.0.7 (23-09-2026) ## 1.3.0.7 (23-09-2026)
- Rebuilt against the current upstream `benkl/firefly-iii-fints-importer` - Rebuilt against the current upstream `benkl/firefly-iii-fints-importer`

2
fireflyiii_fints_importer/config.yaml
View File

@@ -89,5 +89,5 @@ schema:
slug: fireflyiii_fints_importer slug: fireflyiii_fints_importer
udev: true udev: true
url: https://github.com/alexbelgium/hassio-addons url: https://github.com/alexbelgium/hassio-addons
version: 1.3.0.7 version: 1.3.0.8
webui: "[PROTO:ssl]://[HOST]:[PORT:8080]" webui: "[PROTO:ssl]://[HOST]:[PORT:8080]"

17
fireflyiii_fints_importer/rootfs/etc/cont-init.d/20-folders.sh
View File

@@ -7,20 +7,13 @@ CONFIGSOURCE="/config/addons_config/fireflyiii_fints_importer"
# Create directory # Create directory
mkdir -p "$CONFIGSOURCE" mkdir -p "$CONFIGSOURCE"
# If no file, provide example # Remove the self-referencing link created by previous versions
if [ ! "$(ls -A "${CONFIGSOURCE}")" ] && [ -f /data/configurations ]; then if [ -L "$CONFIGSOURCE/fireflyiii_fints_importer" ]; then
cp -r /data/configurations/* "$CONFIGSOURCE"/ || true rm "$CONFIGSOURCE/fireflyiii_fints_importer"
rm -r /data/configurations
fi fi
if [ ! "$(ls -A "${CONFIGSOURCE}")" ] && [ -f /app/configurations ]; then # The app reads data/configurations; -n replaces the link kept in /data instead of nesting a new one inside it
cp -r /app/configurations/* "$CONFIGSOURCE"/ || true ln -sfn "$CONFIGSOURCE" /data/configurations
rm -r /app/configurations
fi
ln -sf "$CONFIGSOURCE" /data/configurations
mkdir -p /app
ln -sf "$CONFIGSOURCE" /app/configurations
# Make sure permissions are right # Make sure permissions are right
chown -R "$(id -u):$(id -g)" "$CONFIGSOURCE" chown -R "$(id -u):$(id -g)" "$CONFIGSOURCE"