allow mount by label

cloudcommander/CHANGELOG.md

@@ -1,3 +1,4 @@
+- Allow mounting local drives by label. Just pust the label instead of sda1 for example
 - Allow uploads >16mb
 - Allow mounting local drives in protected mode
 - Allow mounting of devices up to sdg2

cloudcommander/README.md

@@ -17,13 +17,13 @@ This addon is based on the [docker image](https://hub.docker.com/r/coderaiser/cl
 Webui can be found at `<your-ip>:8000`.
 
 ```yaml
-"localdisks": "sda1" # Optional, requires priviledged mode
-"networkdisks": "//SERVER/SHARE" # optional, list of smb servers to mount, separated by commas
-"cifsusername": "username" # optional, smb username, same for all smb shares
-"cifspassword": "password" # optional, smb password
-"smbv1": "bool?" # smb v1
-"DROPBOX_TOKEN": "str?" # see https://cloudcmd.io/
-"CUSTOM_OPTIONS": "--name Homeassistant" # custom options from https://cloudcmd.io/
+localdisks: sda1 #put the hardware name of your drive to mount separated by commas, or its label. Ex: sda1, sdb1, MYNAS...
+networkdisks: "//SERVER/SHARE" # optional, list of smb servers to mount, separated by commas
+cifsusername: "username" # optional, smb username, same for all smb shares
+cifspassword: "password" # optional, smb password
+smbv1: "bool?" # smb v1
+DROPBOX_TOKEN: "str?" # see https://cloudcmd.io/
+CUSTOM_OPTIONS: "--name Homeassistant" # custom options from https://cloudcmd.io/
 ```
 
 ## Installation

cloudcommander/rootfs/92-local_mounts.sh

@@ -4,8 +4,6 @@
 # MOUNT LOCAL SHARES #
 ######################
 
-
-
 # Mount local Share if configured
 if bashio::config.has_value 'localdisks'; then
 
@@ -14,10 +12,21 @@ if bashio::config.has_value 'localdisks'; then
 
   # Separate comma separated values
   for disk in ${MOREDISKS//,/ }; do
-    # Mount each disk
+
+    # Mount by device as default
+    devpath=/dev
+
+    # Mount as label
+    [ ${disk:0:2} != "sd" ] && devpath=/dev/disk/by-label
+
+    # Creates dir
     mkdir -p /mnt/$disk
     chown -R $(id -u):$(id -g) /mnt/$disk
-    [ -d /share/$disk ] && mount /dev/$disk /share/$disk || true
-    mount /dev/$disk /mnt/$disk && bashio::log.info "Success! $disk mounted to /mnt/$disk" || (bashio::log.fatal "Unable to mount local drives!" && rmdir /mnt/$disk)
+    # Legacy mounting : mount to share if still exists (avoid breaking changes)
+    [ -d /share/$disk ] && mount $devpath/$disk /share/$disk || true
+    # Mount
+    mount $devpath/$disk /mnt/$disk && bashio::log.info "Success! $disk mounted to /mnt/$disk" || (bashio::log.fatal "Unable to mount local drives! Please check the name." && rmdir /mnt/$disk)
+
   done
+
 fi