From cf37b469c0123231c324979418814a56f1c41d09 Mon Sep 17 00:00:00 2001 From: alexbelgium Date: Fri, 4 Sep 2026 08:40:16 +0200 Subject: [PATCH] fix(calibre-web): publish kepubify under a name calibre-web accepts The first attempt was incomplete. It read binary_helper.py at calibre-web master, which accepts a bare "kepubify"; the shipped 0.6.27 tag does not: SUPPORTED_KEPUBIFY_BINARIES = ("kepubify-linux-64bit", "kepubify-linux-32bit") So there are two independent defects, and the chmod only fixed one. The base image installs the converter with `curl -o /usr/bin/kepubify`, which leaves it mode 0644 *and* names it something calibre-web will not look for. A symlink alone does not fix it either: os.access() follows the symlink and tests the target, and the target has no execute bit for anyone, root included. Verified against the exact 0.6.27 resolution logic, on a scratch tree: symlink only -> '' (still broken) chmod only -> '' (still broken) chmod 0755 + symlink -> '/opt/kepubify' Put the symlink in /opt/kepubify, which is where calibre-web's own autodetect_kepubify_binary() already looks, rather than in /usr/bin where only our own database write would find it. init_config() re-runs that detection on every start while the column is NULL, so calibre-web now configures the path itself and a fresh install needs no second restart. That in turn shrinks the cont-init statement: instead of hardcoding a path it resets an empty value to NULL, which un-sticks calibre-web's own detection for installs that already persisted "". A path set by hand is not empty and is left alone. Mode measured on the published add-on image, all 28 layers scanned: ghcr.io/alexbelgium/calibre_web-aarch64:0.6.27.3 carries usr/bin/kepubify at mode 0o644 in the base layer and nowhere else. Reported by @andMaximus in https://github.com/alexbelgium/hassio-addons/issues/3040 Co-Authored-By: Claude Opus 5 --- calibre_web/CHANGELOG.md | 6 +++--- calibre_web/Dockerfile | 16 +++++++++++----- .../rootfs/etc/cont-init.d/80-configuration.sh | 13 +++++++------ 3 files changed, 21 insertions(+), 14 deletions(-) diff --git a/calibre_web/CHANGELOG.md b/calibre_web/CHANGELOG.md index 70acafb852..999ca91fe3 100644 --- a/calibre_web/CHANGELOG.md +++ b/calibre_web/CHANGELOG.md @@ -1,7 +1,7 @@ -## 0.6.27.4 (2026-09-03) -- Fix: Kobo sync could not be enabled, failing with "Kepubify binary not found" even when the path was set to `/usr/bin` by hand. The LinuxServer base image downloads `/usr/bin/kepubify` with `curl -o` and never marks it executable (mode 0644), and calibre-web only accepts a binary that passes `os.access(X_OK)`. The addon now sets mode 0755 on it at build time (https://github.com/alexbelgium/hassio-addons/issues/3040) -- Fix: calibre-web only looks for kepubify under `/opt/kepubify`, never `/usr/bin` where the base image puts it, so the kepubify path was stored empty on the first start and never retried. The addon now fills it in with `/usr/bin` when it is still empty, leaving a path set by hand untouched. On a brand new install `/config/app.db` does not exist yet during the first start, so the path is filled in on the second start, as is already the case for the ingress settings +## 0.6.27.4 (2026-09-04) +- Fix: Kobo sync could not be enabled, failing with "Kepubify binary not found" even when the path was set by hand. The LinuxServer base image installs the converter as `/usr/bin/kepubify` with `curl -o`, which leaves it mode 0644 and gives it a name calibre-web does not accept : `binary_helper.py` only takes `kepubify-linux-64bit` or `kepubify-linux-32bit`, and only when `os.access(X_OK)` passes. The addon now makes the binary executable and publishes it as `/opt/kepubify/kepubify-linux-64bit`, the directory calibre-web's own autodetection already probes, so the path is filled in without any manual step (https://github.com/alexbelgium/hassio-addons/issues/3040) +- Fix: on installs created before that change, calibre-web had already run its autodetection once, found nothing usable and stored an empty path, and it never retries. An empty path is now reset so calibre-web detects the converter itself at the next start. A path set by hand is left alone ## 0.6.27.3 (2026-08-30) - Doc: explain in the README that Calibre-Web's optional extras (metadata, kobo, gdrive, gmail, goodreads, ldap, oauth, comics) are already installed by the LinuxServer base image, that `pip install calibreweb[...]` inside the container is useless and not persistent, and that the cover fields on the Edit Metadata page are gated on `Enable Uploads` plus the user's `Upload` permission (https://github.com/alexbelgium/hassio-addons/issues/1143) diff --git a/calibre_web/Dockerfile b/calibre_web/Dockerfile index 07cfac7a00..1203d21e75 100644 --- a/calibre_web/Dockerfile +++ b/calibre_web/Dockerfile @@ -45,13 +45,19 @@ ARG CONFIGLOCATION="/config" RUN chmod 744 /ha_lsio.sh && if grep -qr "lsio" /etc; then /ha_lsio.sh "$CONFIGLOCATION"; fi && rm /ha_lsio.sh # Specific images modifications -# The base image installs kepubify with "curl -o /usr/bin/kepubify" and never marks it executable, -# so calibre-web's resolve_binary_path() rejects it (it requires os.access(X_OK)) and enabling -# Kobo sync fails with "Kepubify binary not found". Unguarded on purpose: if a future base image -# stops shipping the binary, the build must fail here rather than ship a silently broken add-on. +# The base image installs kepubify with "curl -o /usr/bin/kepubify", which both leaves it mode +# 0644 and gives it a name calibre-web does not accept : binary_helper.py only takes +# "kepubify-linux-64bit" or "kepubify-linux-32bit", and only when os.access(X_OK) passes. Both +# defects have to be fixed, which is why enabling Kobo sync failed with "Kepubify binary not +# found" even when the path was set by hand. Publish it under an accepted name in /opt/kepubify, +# the directory calibre-web's own autodetect_kepubify_binary() already probes, so calibre-web +# fills the setting in itself. Unguarded on purpose: if a future base image stops shipping the +# binary, the build must fail here rather than ship a silently broken add-on. RUN \ usermod --home /config abc \ - && chmod 0755 /usr/bin/kepubify + && chmod 0755 /usr/bin/kepubify \ + && mkdir -p /opt/kepubify \ + && ln -s /usr/bin/kepubify /opt/kepubify/kepubify-linux-64bit ################## # 3 Install apps # diff --git a/calibre_web/rootfs/etc/cont-init.d/80-configuration.sh b/calibre_web/rootfs/etc/cont-init.d/80-configuration.sh index 3194cbd83a..1edd958d91 100755 --- a/calibre_web/rootfs/etc/cont-init.d/80-configuration.sh +++ b/calibre_web/rootfs/etc/cont-init.d/80-configuration.sh @@ -33,12 +33,13 @@ else trusted_ips_error=$(sqlite3 /config/app.db "update settings set config_reverse_proxy_trusted_ips='127.0.0.1,::1,::ffff:127.0.0.1,172.30.32.0/23,::ffff:172.30.32.0/119,'||coalesce(config_reverse_proxy_trusted_ips,'') where coalesce(config_reverse_proxy_trusted_ips,'') not like '%::ffff:172.30.32.0/119%'" 2>&1) || bashio::log.warning "Could not set the ingress trusted ip list, it will be applied at next start (${trusted_ips_error})" - # Calibre-web only autodetects kepubify under /opt/kepubify, never /usr/bin where the base - # image puts it, so the setting is stored empty on the very first start and is never retried - # afterwards : every install ends up with an empty path and Kobo sync cannot be enabled. - # Filled in only when it is still empty, so a path the user set by hand is never overwritten. - kepubify_error=$(sqlite3 /config/app.db "update settings set config_kepubifypath='/usr/bin' where coalesce(config_kepubifypath,'') = ''" 2>&1) || - bashio::log.warning "Could not set the kepubify path, it will be applied at next start (${kepubify_error})" + # Calibre-web autodetects kepubify only while this setting is still NULL. On every install + # that predates the Dockerfile fix above, that detection already ran, found nothing usable and + # stored an empty string, so it is never retried. Put an empty value back to NULL and + # calibre-web detects /opt/kepubify itself when it starts, a few seconds after this runs. + # A path the user set by hand is not empty and is left alone. + kepubify_error=$(sqlite3 /config/app.db "update settings set config_kepubifypath = NULL where config_kepubifypath = ''" 2>&1) || + bashio::log.warning "Could not reset the kepubify path, it will be applied at next start (${kepubify_error})" fi bashio::log.info "Default username:password is admin:admin123"