avm/hassio-addons
1
0
Fork 0
mirror of https://github.com/alexbelgium/hassio-addons.git synced 2026-08-28 07:43:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(birdnet-pi): healthcheck must select https for ssl=true and use POSIX redirection

Browse Source 
The healthcheck CMD hardcoded http://, but 92-ssl.sh switches Caddy to
https://:8081 when ssl=true, so the probe would fail with the wrong scheme.
Select the scheme from the ssl env var and pass -k (the probe hits
127.0.0.1, not the certificate's real name).

Also replace `&>/dev/null` with `>/dev/null 2>&1`. HEALTHCHECK's shell form
runs under /bin/sh, which in this image is dash, not bash. Dash parses
`cmd &>/dev/null` as `cmd &` (backgrounded) followed by a separate no-op
`>/dev/null`, discarding curl's exit status entirely -- so the healthcheck
always reported healthy regardless of whether the WebUI actually responded.
Verified under dash directly: no listener -> exit 1, http server -> exit 0,
forced scheme mismatch -> exit 1, https with self-signed cert + -k -> exit 0.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
alexbelgium
2026-07-22 10:52:19 +02:00
parent 9bfad91d7b
commit e554279fc3
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
birdnet-pi/CHANGELOG.md
View File

@@ -1,5 +1,6 @@
## 2026.07.22 (22-07-2026) ## 2026.07.22 (22-07-2026)
- Fix: health-check the WebUI port (8081) instead of port 80, so the standalone Docker container no longer reports "unhealthy" when ssl=false - Fix: health-check the WebUI port (8081) instead of port 80, so the standalone Docker container no longer reports "unhealthy" when ssl=false
- Fix: health-check now probes https when ssl is enabled, and no longer silently reports "healthy" regardless of the actual result (the previous check's `&>` redirection is a bash-ism that dash, the image's /bin/sh, parses as background + no-op, discarding curl's exit status)
## 2026.07.10 (10-07-2026) ## 2026.07.10 (10-07-2026)
- Minor bugs fixed - Minor bugs fixed
## 2026.06.01 (19-06-2026) ## 2026.06.01 (19-06-2026)

7
birdnet-pi/Dockerfile
View File

@@ -241,6 +241,11 @@ RUN \
# Health-check the actual WebUI port. In standalone Docker (no Supervisor) nginx # Health-check the actual WebUI port. In standalone Docker (no Supervisor) nginx
# is disabled and Caddy serves the UI on 8081; nothing listens on port 80 when # is disabled and Caddy serves the UI on 8081; nothing listens on port 80 when
# ssl=false, which made the container report "unhealthy" even though it worked. # ssl=false, which made the container report "unhealthy" even though it worked.
# Select https when ssl is enabled (92-ssl.sh switches Caddy to https://:8081),
# and use -k since the probe hits 127.0.0.1 rather than the cert's real name.
# Note: the shell form's CMD runs under /bin/sh (dash here, not bash), so this
# avoids "&>" (a bash-only redirection dash parses as background + no-op,
# which silently discarded curl's exit status and made the check always pass).
ENV HEALTH_PORT="8081" \ ENV HEALTH_PORT="8081" \
HEALTH_URL="" HEALTH_URL=""
HEALTHCHECK \ HEALTHCHECK \
@@ -248,4 +253,4 @@ HEALTHCHECK \
--retries=5 \ --retries=5 \
--start-period=30s \ --start-period=30s \
--timeout=25s \ --timeout=25s \
CMD curl -A "HealthCheck: Docker/1.0" -s -f "http://127.0.0.1:${HEALTH_PORT}${HEALTH_URL}" &>/dev/null || exit 1 CMD scheme=http; case "${ssl:-false}" in true|TRUE|True|1|yes|YES|Yes|on|ON|On) scheme=https ;; esac; curl -A "HealthCheck: Docker/1.0" -s -k -f "${scheme}://127.0.0.1:${HEALTH_PORT}${HEALTH_URL}" >/dev/null 2>&1 || exit 1