From efa5ed9b59417d3d20f06e638a25215fde8d63e9 Mon Sep 17 00:00:00 2001
From: ToledoEM <8144940+ToledoEM@users.noreply.github.com>
Date: Sat, 11 Jul 2026 12:26:19 +0100
Subject: [PATCH] coderabbitai suggestions

---
 nginx_webserver_proxy/run.sh | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/nginx_webserver_proxy/run.sh b/nginx_webserver_proxy/run.sh
index 62085cbe64..452b512c57 100755
--- a/nginx_webserver_proxy/run.sh
+++ b/nginx_webserver_proxy/run.sh
@@ -115,7 +115,10 @@ log "static_site_root=${STATIC_ROOT} prefix=${STATIC_PREFIX} log_level=${LOG_LEV
 # Supervisor persists /data as a Docker volume; /etc/letsencrypt would otherwise be ephemeral.
 if [ ! -L /etc/letsencrypt ]; then
     if [ -d /etc/letsencrypt ] && [ "$(ls -A /etc/letsencrypt 2> /dev/null)" ]; then
-        cp -a /etc/letsencrypt/. /data/letsencrypt/ 2> /dev/null || true
+        # Abort migration on copy failure so we never rm -rf certs that weren't copied.
+        mkdir -p /data/letsencrypt
+        cp -a /etc/letsencrypt/. /data/letsencrypt/ \
+            || die "Failed to migrate /etc/letsencrypt to /data/letsencrypt; leaving existing certs intact"
     fi
     rm -rf /etc/letsencrypt
     ln -sf /data/letsencrypt /etc/letsencrypt