From f70b17b384f0611a246fd4301188e6cb7d9fb4b3 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 2 Apr 2026 09:29:34 +0000 Subject: [PATCH] Address code review: explicit nginx config path, unused var, consistent capitalization Agent-Logs-Url: https://github.com/alexbelgium/hassio-addons/sessions/14f6643d-9d4f-4c6d-8993-0dbe4404c35d Co-authored-by: alexbelgium <44178713+alexbelgium@users.noreply.github.com> --- maintainerr/rootfs/etc/cont-init.d/32-nginx_ingress.sh | 4 ++-- maintainerr/rootfs/ha_entrypoint.sh | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/maintainerr/rootfs/etc/cont-init.d/32-nginx_ingress.sh b/maintainerr/rootfs/etc/cont-init.d/32-nginx_ingress.sh index c23bc60a1..abb012724 100644 --- a/maintainerr/rootfs/etc/cont-init.d/32-nginx_ingress.sh +++ b/maintainerr/rootfs/etc/cont-init.d/32-nginx_ingress.sh @@ -9,7 +9,7 @@ set -e declare ingress_interface declare ingress_port -bashio::log.info "Configuring Nginx for ingress..." +bashio::log.info "Configuring NGinx for ingress..." ingress_port=$(bashio::addon.ingress_port) ingress_interface=$(bashio::addon.ip_address) @@ -19,4 +19,4 @@ sed -i "s/%%port%%/${ingress_port}/g" /etc/nginx/servers/ingress.conf sed -i "s/%%interface%%/${ingress_interface}/g" /etc/nginx/servers/ingress.conf sed -i "s|%%ingress_entry%%|${ingress_entry}|g" /etc/nginx/servers/ingress.conf -bashio::log.info "Nginx ingress configured on ${ingress_interface}:${ingress_port}" +bashio::log.info "NGinx ingress configured on ${ingress_interface}:${ingress_port}" diff --git a/maintainerr/rootfs/ha_entrypoint.sh b/maintainerr/rootfs/ha_entrypoint.sh index b58c5259a..dd0aa8b30 100755 --- a/maintainerr/rootfs/ha_entrypoint.sh +++ b/maintainerr/rootfs/ha_entrypoint.sh @@ -62,11 +62,11 @@ gosu node /opt/app/start.sh & # ─── Wait for Maintainerr to become available, then start Nginx ────────────── echo "[Maintainerr] Waiting for application to be ready..." -for i in $(seq 1 900); do +for _ in $(seq 1 900); do if curl -s -o /dev/null -f "http://127.0.0.1:${UI_PORT:-6246}" 2>/dev/null; then break fi sleep 1 done echo "[Maintainerr] Starting NGinx..." -exec nginx +exec nginx -c /etc/nginx/nginx.conf