diff --git a/.templates/90-dns_set.sh b/.templates/90-dns_set.sh index b83d1bc5a..4908ee163 100644 --- a/.templates/90-dns_set.sh +++ b/.templates/90-dns_set.sh @@ -16,6 +16,7 @@ if bashio::config.has_value 'DNS_server'; then # Get DNS servers # shellcheck disable=SC2086 for server in ${DNSSERVER//,/ }; do # Separate comma separated values + # Only add DNS if successful if ping -c 1 "$server" &> /dev/null then DNS="${DNS}nameserver $server\n" @@ -25,11 +26,17 @@ if bashio::config.has_value 'DNS_server'; then fi done - # Write resolv.conf - # shellcheck disable=SC2059 - printf "${DNS}" >/etc/resolv.conf - chmod 644 /etc/resolv.conf - bashio::log.info "DNS SERVERS set to $DNSLIST" + # Only add DNS if there are DNS set + if [[ ! -z "$DNS" ]]; then + # Write resolv.conf + # shellcheck disable=SC2059 + printf "${DNS}" >/etc/resolv.conf + chmod 644 /etc/resolv.conf + bashio::log.info "DNS SERVERS set to $DNSLIST" + else + bashio::log.warning "No valid DNS were found. Using default router (or HA) dns servers." + fi + else bashio::log.info "DNS Servers option empty. Using default router (or HA) dns servers." fi