mirror of
https://github.com/alexbelgium/hassio-addons.git
synced 2026-10-16 13:09:25 +02:00
8142df0596
* fix(calibre-web): make kepubify executable so Kobo sync can be enabled The LinuxServer base image installs kepubify with `curl -o /usr/bin/kepubify` and never marks it executable, so the file ships as mode 0644. Calibre-web's resolve_binary_path() only accepts a binary that passes os.access(X_OK), so enabling Kobo sync failed with "Kepubify binary not found" even when the path was set to /usr/bin by hand. Verified against the published layer of lscr.io/linuxserver/calibre-web:arm64v8-latest, whose tar header for usr/bin/kepubify reads `-rw-r--r-- 0/0 3670016`. Set mode 0755 on it at build time, unguarded: if a future base image stops shipping the binary, the build should fail rather than ship a broken add-on. Calibre-web separately only autodetects kepubify under /opt/kepubify, never /usr/bin, so the setting was stored empty on the first start and never retried. Fill it in with /usr/bin from the cont-init script that already applies conditional settings to app.db, and only while it is still empty, so a path the user set by hand is never overwritten. Fixes https://github.com/alexbelgium/hassio-addons/issues/3040 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(calibre-web): publish kepubify under a name calibre-web accepts The first attempt was incomplete. It read binary_helper.py at calibre-web master, which accepts a bare "kepubify"; the shipped 0.6.27 tag does not: SUPPORTED_KEPUBIFY_BINARIES = ("kepubify-linux-64bit", "kepubify-linux-32bit") So there are two independent defects, and the chmod only fixed one. The base image installs the converter with `curl -o /usr/bin/kepubify`, which leaves it mode 0644 *and* names it something calibre-web will not look for. A symlink alone does not fix it either: os.access() follows the symlink and tests the target, and the target has no execute bit for anyone, root included. Verified against the exact 0.6.27 resolution logic, on a scratch tree: symlink only -> '' (still broken) chmod only -> '' (still broken) chmod 0755 + symlink -> '/opt/kepubify' Put the symlink in /opt/kepubify, which is where calibre-web's own autodetect_kepubify_binary() already looks, rather than in /usr/bin where only our own database write would find it. init_config() re-runs that detection on every start while the column is NULL, so calibre-web now configures the path itself and a fresh install needs no second restart. That in turn shrinks the cont-init statement: instead of hardcoding a path it resets an empty value to NULL, which un-sticks calibre-web's own detection for installs that already persisted "". A path set by hand is not empty and is left alone. Mode measured on the published add-on image, all 28 layers scanned: ghcr.io/alexbelgium/calibre_web-aarch64:0.6.27.3 carries usr/bin/kepubify at mode 0o644 in the base layer and nowhere else. Reported by @andMaximus in https://github.com/alexbelgium/hassio-addons/issues/3040 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(calibre-web): keep /usr/bin resolving for the manual workaround CodeRabbit spotted that an install already storing "/usr/bin" stays broken: that value is not empty, so the cont-init statement leaves it alone, and with the symlink only in /opt/kepubify it no longer resolves under 0.6.27. The case is real and narrow. A failed save never persists the value -- _configuration_result() calls config.load() on the error path, discarding it -- so the only way to hold "/usr/bin" is a save that succeeded, which requires having first applied the workaround published in the issue thread: ln -sf /usr/bin/kepubify /usr/bin/kepubify-linux-64bit Anyone who did that, and anyone copying that comment, would have been broken again by this PR. Fixed with one more symlink rather than CodeRabbit's suggested migration of "/usr/bin" back to NULL, because that would overwrite a path the user set by hand. Making their setting keep working is better than resetting it. Verified against the 0.6.27 resolution logic: symlink in /opt only stored '/usr/bin' -> '' plus /usr/bin symlink stored '/usr/bin' -> '/usr/bin/kepubify-linux-64bit' autodetect -> '/opt/kepubify' Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
121 lines
2.1 KiB
YAML
121 lines
2.1 KiB
YAML
arch:
|
|
- aarch64
|
|
- amd64
|
|
description: Browsing, reading and downloading eBooks using an existing Calibre database
|
|
devices:
|
|
- /dev/dri
|
|
- /dev/dri/card0
|
|
- /dev/dri/card1
|
|
- /dev/dri/renderD128
|
|
- /dev/vchiq
|
|
- /dev/video10
|
|
- /dev/video11
|
|
- /dev/video12
|
|
- /dev/video13
|
|
- /dev/video14
|
|
- /dev/video15
|
|
- /dev/video16
|
|
- /dev/ttyUSB0
|
|
- /dev/sda
|
|
- /dev/sdb
|
|
- /dev/sdc
|
|
- /dev/sdd
|
|
- /dev/sde
|
|
- /dev/sdf
|
|
- /dev/sdg
|
|
- /dev/nvme
|
|
- /dev/nvme0
|
|
- /dev/nvme0n1
|
|
- /dev/nvme0n1p1
|
|
- /dev/nvme0n1p2
|
|
- /dev/nvme0n1p3
|
|
- /dev/nvme1n1
|
|
- /dev/nvme1n1p1
|
|
- /dev/nvme1n1p2
|
|
- /dev/nvme1n1p3
|
|
- /dev/nvme2n1
|
|
- /dev/nvme2n1p1
|
|
- /dev/nvme2n1p2
|
|
- /dev/nvme2n3p3
|
|
- /dev/mmcblk
|
|
- /dev/fuse
|
|
- /dev/sda1
|
|
- /dev/sdb1
|
|
- /dev/sdc1
|
|
- /dev/sdd1
|
|
- /dev/sde1
|
|
- /dev/sdf1
|
|
- /dev/sdg1
|
|
- /dev/sda2
|
|
- /dev/sdb2
|
|
- /dev/sdc2
|
|
- /dev/sdd2
|
|
- /dev/sde2
|
|
- /dev/sdf2
|
|
- /dev/sdg2
|
|
- /dev/sda3
|
|
- /dev/sdb3
|
|
- /dev/sda4
|
|
- /dev/sdb4
|
|
- /dev/sda5
|
|
- /dev/sda6
|
|
- /dev/sda7
|
|
- /dev/sda8
|
|
- /dev/nvme0
|
|
- /dev/nvme1
|
|
- /dev/nvme2
|
|
environment:
|
|
DOCKER_MODS: linuxserver/mods:universal-calibre
|
|
FM_HOME: /config
|
|
HOME: /config
|
|
PGID: "0"
|
|
PUID: "0"
|
|
calibre-web_CONFIG_DIRECTORY: /config
|
|
shm_size: 1gb
|
|
hassio_api: true
|
|
image: ghcr.io/alexbelgium/calibre_web-{arch}
|
|
ingress: true
|
|
init: false
|
|
map:
|
|
- addon_config:rw
|
|
- all_addon_configs:rw
|
|
- homeassistant_config:rw
|
|
- media:rw
|
|
- share:rw
|
|
- ssl
|
|
name: Calibre-web
|
|
options:
|
|
env_vars: []
|
|
PGID: 0
|
|
PUID: 0
|
|
panel_admin: false
|
|
panel_icon: mdi:library
|
|
ports:
|
|
8083/tcp: 8084
|
|
ports_description:
|
|
8083/tcp: Calibre-web webui (Not required for Ingress)
|
|
privileged:
|
|
- SYS_ADMIN
|
|
- DAC_READ_SEARCH
|
|
- NET_ADMIN
|
|
schema:
|
|
env_vars:
|
|
- name: match(^[A-Za-z0-9_]+$)
|
|
value: str?
|
|
DOCKER_MODS: str?
|
|
OAUTHLIB_RELAX_TOKEN_SCOPE: str?
|
|
PGID: int
|
|
PUID: int
|
|
TZ: str?
|
|
cifsdomain: str?
|
|
cifspassword: str?
|
|
cifsusername: str?
|
|
ingress_user: str?
|
|
localdisks: str?
|
|
networkdisks: str?
|
|
slug: calibre-web
|
|
udev: true
|
|
url: https://github.com/alexbelgium/hassio-addons/tree/master/calibre_web
|
|
version: "0.6.27.4"
|
|
video: true
|