mirror of
https://github.com/alexbelgium/hassio-addons.git
synced 2026-09-21 01:04:00 +02:00
d0ef2fec48
* feat(comicarr): new add-on with Home Assistant ingress Comicarr is a fork of Mylar3 with a React frontend and a FastAPI backend. The upstream image is a plain python:3.12-slim with no s6-overlay, so ha_entrypoint.sh runs as pid 1 and supervises both the app and nginx — the same shape the komga add-on uses. Ingress needs a reverse proxy because the app has no url-base support of any kind: vite emits absolute /assets urls, the api client and the cover img tags build absolute /api and /cache urls, and SecurityHeadersMiddleware sends X-Frame-Options: DENY together with a CSP carrying frame-ancestors 'none', which alone would leave the panel blank. The bundled nginx rewrites those paths onto the ingress entry, replaces the two framing headers with the same policy narrowed to the Home Assistant origin, scopes the session cookie to the ingress path and drops upstream's one-year immutable caching for the rewritten assets. The app is started directly as root by default rather than through the upstream /entrypoint.sh, which runs useradd -u "$PUID" under set -e and would exit on this repo's PUID=0 default; that entrypoint is still used when the user asks for an unprivileged uid. --port 8090 is forced because the port is writable from the Settings page and changing it there would silently break both the proxy and the health check. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(comicarr): note that switching PUID leaves existing files root-owned Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(comicarr): drop ingress_port, the add-on linter rejects the default 8099 is the Supervisor default, and frenck/action-addon-linter fails with "'ingress_port' should be removed, it uses a default value". komga omits it for the same reason; nginx still binds whatever bashio::addon.ingress_port reports. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(comicarr): 0755 on the entrypoint instead of 777 The rest of the repo uses 777 here, but this add-on is the one that offers a non-root mode: with PUID set, the app runs as an unprivileged user that could otherwise rewrite a file docker executes as root on the next start. Nothing writes to /ha_entrypoint.sh at runtime, so 0755 costs nothing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
36 lines
1.6 KiB
Plaintext
36 lines
1.6 KiB
Plaintext
#!/usr/bin/with-contenv bashio
|
|
# shellcheck shell=bash
|
|
set -e
|
|
# ==============================================================================
|
|
|
|
# Wait for Comicarr to answer before nginx starts serving ingress. First boot
|
|
# runs the alembic migrations against a cold database, so leave a wide margin,
|
|
# but poll rather than call bashio::net.wait_for : bashio takes (port host
|
|
# timeout) while the bundled bashio-standalone.sh takes (host port timeout), and
|
|
# picking the wrong one would either fail instantly or block for the whole
|
|
# timeout.
|
|
# The per probe timeouts keep the 15 minute ceiling real : without them a half
|
|
# open connection would hang a single probe, and the loop, forever.
|
|
# A wall clock deadline, not an attempt count : a failed probe costs up to
|
|
# max-time on top of the sleep, so counting attempts would stretch the wait to
|
|
# roughly twice the advertised ceiling.
|
|
comicarr_ready=false
|
|
deadline=$((SECONDS + 900))
|
|
while [ "$SECONDS" -lt "$deadline" ]; do
|
|
if curl -sf --connect-timeout 2 --max-time 5 -o /dev/null "http://127.0.0.1:8090/api/health"; then
|
|
comicarr_ready=true
|
|
break
|
|
fi
|
|
sleep 5
|
|
done
|
|
|
|
# Deliberately not fatal : nginx serving a 502 tells the user something is wrong
|
|
# and starts working by itself once Comicarr finally answers, while refusing to
|
|
# start would take ingress down for good after ha_entrypoint gives up retrying.
|
|
if [ "$comicarr_ready" != true ]; then
|
|
bashio::log.warning "Comicarr did not answer within 15 minutes. Starting NGinx anyway : ingress will return 502 until it does."
|
|
fi
|
|
|
|
bashio::log.info "Starting NGinx..."
|
|
exec nginx
|