mirror of
https://github.com/alexbelgium/hassio-addons.git
synced 2026-09-14 13:49:09 +02:00
88faf503fb
* fix(transmission): let incomplete-dir stay off across restarts 01-config.sh rewrites Transmission's settings.json on every restart, deriving "incomplete-dir-enabled" purely from whether incomplete_dir is non-empty. Since incomplete_dir defaults to a non-empty path, any toggle made in Transmission's own Web UI was silently overwritten back to enabled on the next restart (#3059). Add incomplete_dir_enabled (bool, default true): setting it to false writes the disabled state on every restart instead of forcing it back on. The default of true preserves normal existing configurations unchanged; the two edge cases it also touches were already latent bugs, see below. While touching this line: bashio::config's own default-value argument cannot be an empty string (bash's ${2:-null} treats "" as unset), so an install whose incomplete_dir key was entirely absent, or literally the four characters "null", returned bashio's own "null" fallback and would have created a directory named "null". Normalized that explicitly; both now disable instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(transmission): keep incomplete-dir enabled on upgrade in standalone mode The previous commit relied on bashio::config's default argument to treat an absent incomplete_dir_enabled as true. The standalone shim (.templates/bashio-standalone.sh), injected by 00-banner.sh when the image runs without Supervisor, ignores that argument and returns "" for a missing key, so an upgraded standalone install would have silently disabled its incomplete directory. Treat anything but an explicit "false" as enabled instead. That covers real bashio ("null") and the shim ("") alike, and drops the default argument altogether. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>