Compare commits

...

5 Commits

Author SHA1 Message Date
Alexandre
9e6ecedbc1 Merge pull request #2702 from alexbelgium/claude/fix-qbittorrent-arm64-startup-zFYXB
Fix qbittorrent startup loop on aarch64: drop s6-notifyoncheck
2026-05-11 07:19:43 +02:00
Claude
f5328b6d66 Fix aarch64 startup loop: /proc/1/fd/1 + notification-fd guard
Two independent failure modes can cause the restart loop on arm64:

1. /dev/stdout may be inaccessible in some ARM container runtimes; replaced
   with /proc/1/fd/1 which LSIO images already use for direct container stdout.

2. s6-notifyoncheck writes to fd 3 on check success, but s6-rc only opens
   that fd when notification-fd exists in the service directory. LSIO arm64
   images ship svc-qbittorrent without it, so s6-notifyoncheck exits with
   EBADF and s6 restarts the service in a loop. Guard with a file check and
   fall back to exec'ing qbittorrent-nox directly when the file is absent.

https://claude.ai/code/session_01F16ThtZyfXj6ZKFPkrSAAq
2026-05-11 05:19:13 +00:00
Claude
862097d6bd Fix aarch64 startup loop: use /proc/1/fd/1 instead of /dev/stdout
/dev/stdout resolves via /proc/self/fd/1 and can be inaccessible in some
ARM container runtimes, causing the exec redirect to fail and s6 to restart
the service in a loop. /proc/1/fd/1 is the path LSIO images already use
for direct container stdout (see nginx silent-mode handling) and is reliable
across architectures.

https://claude.ai/code/session_01F16ThtZyfXj6ZKFPkrSAAq
2026-05-11 05:17:32 +00:00
Claude
e5048aa378 Fix aarch64 startup loop: use s6-notifyoncheck only when notification-fd exists
s6-rc opens fd 3 for a longrun service only when a notification-fd file is
present in the service directory. The LSIO aarch64 image ships svc-qbittorrent
without that file, so fd 3 is never opened. s6-notifyoncheck exits with EBADF
after its readiness check passes, s6 treats the supervised process as dead and
immediately restarts it — producing the infinite "Starting qBittorrent..." loop.

Check for the notification-fd file at runtime: use the full s6-notifyoncheck
path when it is present (amd64, preserving existing behaviour), and fall back
to exec'ing qbittorrent-nox directly when it is absent (aarch64).

https://claude.ai/code/session_01F16ThtZyfXj6ZKFPkrSAAq
2026-05-11 05:16:13 +00:00
Claude
8bdb3897da Fix qbittorrent startup loop on aarch64: drop s6-notifyoncheck
s6-notifyoncheck writes to fd 3 when its readiness check passes, but
the LSIO aarch64 image's svc-qbittorrent service has no notification-fd
file so s6-rc never opens fd 3. s6-notifyoncheck exits with EBADF, s6
sees the supervised process die and immediately restarts it, producing
the infinite "Starting qBittorrent..." loop seen on odroid-c2 and other
aarch64 boards.

Drop s6-notifyoncheck entirely and exec qbittorrent-nox directly under
s6-setuidgid so s6 supervises the real process. Silent mode is handled
by redirecting the shell's fds before exec rather than passing a
/dev/stdout path (avoids a separate class of ARM container fd issues).

https://claude.ai/code/session_01F16ThtZyfXj6ZKFPkrSAAq
2026-05-10 16:30:23 +00:00
3 changed files with 12 additions and 5 deletions

View File

@@ -1,4 +1,7 @@
## 5.2.0-2 (2026-05-10)
- Fix startup loop on aarch64: drop s6-notifyoncheck wrapper so s6 supervises qbittorrent-nox directly (LSIO arm64 image has no notification-fd, causing EBADF restart loop)
## 5.2.0-1 (2026-05-10)
- Fix qbittorrent-nox path (/usr/bin → /app) after LSIO image update

View File

@@ -143,4 +143,4 @@ schema:
slug: qbittorrent
udev: true
url: https://github.com/alexbelgium/hassio-addons
version: "5.2.0-1"
version: "5.2.0-2"

View File

@@ -37,13 +37,17 @@ fi
# --- Launch qBittorrent ---
# Determine log output based on silent mode
QB_OUTPUT="/dev/stdout"
QB_OUTPUT="/proc/1/fd/1"
if bashio::config.true 'silent'; then
QB_OUTPUT="/dev/null"
fi
bashio::log.info "Starting qBittorrent..."
exec \
s6-notifyoncheck -d -n 300 -w 1000 -c "nc -z localhost ${WEBUI_PORT}" \
s6-setuidgid abc /app/qbittorrent-nox --webui-port="${WEBUI_PORT}" > "${QB_OUTPUT}"
if [ -f /etc/s6-overlay/s6-rc.d/svc-qbittorrent/notification-fd ]; then
exec \
s6-notifyoncheck -d -n 300 -w 1000 -c "nc -z localhost ${WEBUI_PORT}" \
s6-setuidgid abc /app/qbittorrent-nox --webui-port="${WEBUI_PORT}" > "${QB_OUTPUT}"
else
exec s6-setuidgid abc /app/qbittorrent-nox --webui-port="${WEBUI_PORT}" > "${QB_OUTPUT}"
fi