Compare commits

...

16 Commits

Author SHA1 Message Date
copilot-swe-agent[bot]
07f5f82e5b fix(qbittorrent): prevent recursive routing with blackhole route in table 1000
Agent-Logs-Url: https://github.com/alexbelgium/hassio-addons/sessions/14f8993e-d073-4a6b-8c36-40ebf1b0e396

Co-authored-by: alexbelgium <44178713+alexbelgium@users.noreply.github.com>
2026-05-13 08:51:23 +00:00
copilot-swe-agent[bot]
96b21edf48 fix(qbittorrent): prevent recursive routing by adding VPN server route to table 1000
Agent-Logs-Url: https://github.com/alexbelgium/hassio-addons/sessions/a702f853-3b84-4896-b792-83ead5a511a6

Co-authored-by: alexbelgium <44178713+alexbelgium@users.noreply.github.com>
2026-05-13 07:59:12 +00:00
copilot-swe-agent[bot]
134348bcfc fix(qbittorrent): correct pre-existing typo openpvn→openvpn in function names
Agent-Logs-Url: https://github.com/alexbelgium/hassio-addons/sessions/becbb21c-f7e7-4937-925d-ac4ae0cf24b0

Co-authored-by: alexbelgium <44178713+alexbelgium@users.noreply.github.com>
2026-05-13 07:33:47 +00:00
copilot-swe-agent[bot]
3c12b13dde fix(qbittorrent): address code review - validate trusted_ip, surface route-add errors, robust gateway parsing
Agent-Logs-Url: https://github.com/alexbelgium/hassio-addons/sessions/becbb21c-f7e7-4937-925d-ac4ae0cf24b0

Co-authored-by: alexbelgium <44178713+alexbelgium@users.noreply.github.com>
2026-05-13 07:32:55 +00:00
github-actions
53109170ca GitHub bot: changelog [nobuild] 2026-05-13 07:19:57 +00:00
Alexandre
9b9157092c Update config.yaml 2026-05-13 09:15:28 +02:00
Alexandre
12e141eacf Update run 2026-05-13 09:15:16 +02:00
github-actions
9a0c7cea5f GitHub bot: changelog [nobuild] 2026-05-11 18:48:18 +00:00
Alexandre
15d14ca9b0 Merge pull request #2705 from ToledoEM/manyfold
Update version Manyfold3D to 0.139.3
2026-05-11 20:46:13 +02:00
Enrique
098f04781b Update version to 0.139.3 in config.yaml
version bump of manyfold
2026-05-11 19:26:52 +01:00
github-actions
575ff2264f Github bot : issues linked to readme 2026-05-11 16:09:06 +00:00
Alexandre
9e6ecedbc1 Merge pull request #2702 from alexbelgium/claude/fix-qbittorrent-arm64-startup-zFYXB
Fix qbittorrent startup loop on aarch64: drop s6-notifyoncheck
2026-05-11 07:19:43 +02:00
Claude
f5328b6d66 Fix aarch64 startup loop: /proc/1/fd/1 + notification-fd guard
Two independent failure modes can cause the restart loop on arm64:

1. /dev/stdout may be inaccessible in some ARM container runtimes; replaced
   with /proc/1/fd/1 which LSIO images already use for direct container stdout.

2. s6-notifyoncheck writes to fd 3 on check success, but s6-rc only opens
   that fd when notification-fd exists in the service directory. LSIO arm64
   images ship svc-qbittorrent without it, so s6-notifyoncheck exits with
   EBADF and s6 restarts the service in a loop. Guard with a file check and
   fall back to exec'ing qbittorrent-nox directly when the file is absent.

https://claude.ai/code/session_01F16ThtZyfXj6ZKFPkrSAAq
2026-05-11 05:19:13 +00:00
Claude
862097d6bd Fix aarch64 startup loop: use /proc/1/fd/1 instead of /dev/stdout
/dev/stdout resolves via /proc/self/fd/1 and can be inaccessible in some
ARM container runtimes, causing the exec redirect to fail and s6 to restart
the service in a loop. /proc/1/fd/1 is the path LSIO images already use
for direct container stdout (see nginx silent-mode handling) and is reliable
across architectures.

https://claude.ai/code/session_01F16ThtZyfXj6ZKFPkrSAAq
2026-05-11 05:17:32 +00:00
Claude
e5048aa378 Fix aarch64 startup loop: use s6-notifyoncheck only when notification-fd exists
s6-rc opens fd 3 for a longrun service only when a notification-fd file is
present in the service directory. The LSIO aarch64 image ships svc-qbittorrent
without that file, so fd 3 is never opened. s6-notifyoncheck exits with EBADF
after its readiness check passes, s6 treats the supervised process as dead and
immediately restarts it — producing the infinite "Starting qBittorrent..." loop.

Check for the notification-fd file at runtime: use the full s6-notifyoncheck
path when it is present (amd64, preserving existing behaviour), and fall back
to exec'ing qbittorrent-nox directly when it is absent (aarch64).

https://claude.ai/code/session_01F16ThtZyfXj6ZKFPkrSAAq
2026-05-11 05:16:13 +00:00
Claude
8bdb3897da Fix qbittorrent startup loop on aarch64: drop s6-notifyoncheck
s6-notifyoncheck writes to fd 3 when its readiness check passes, but
the LSIO aarch64 image's svc-qbittorrent service has no notification-fd
file so s6-rc never opens fd 3. s6-notifyoncheck exits with EBADF, s6
sees the supervised process die and immediately restarts it, producing
the infinite "Starting qBittorrent..." loop seen on odroid-c2 and other
aarch64 boards.

Drop s6-notifyoncheck entirely and exec qbittorrent-nox directly under
s6-setuidgid so s6 supervises the real process. Silent mode is handled
by redirecting the shell's fds before exec rather than passing a
/dev/stdout path (avoids a separate class of ARM container fd issues).

https://claude.ai/code/session_01F16ThtZyfXj6ZKFPkrSAAq
2026-05-10 16:30:23 +00:00
7 changed files with 60 additions and 10 deletions

View File

@@ -1,3 +1,5 @@
## 0.139.3 (11-05-2026)
- Minor bugs fixed
## 0.138.0 (24-04-2026)
- Minor bugs fixed
## 0.137.0 (13-04-2026)

View File

@@ -1,7 +1,7 @@
name: "Manyfold"
slug: manyfold
description: "Manyfold 3D model manager as a Home Assistant add-on, using the upstream image with configurable library/index paths."
version: "0.138.0"
version: "0.139.3"
url: "https://github.com/alexbelgium/hassio-addons/tree/master/manyfold"
image: ghcr.io/alexbelgium/manyfold-{arch}
arch:

View File

@@ -1,3 +1,10 @@
## 5.2.0-19 (13-05-2026)
- OpenVPN: simplify recursive routing fix — use a single blackhole route for the VPN server IP in table 1000 (no AWK, no ipcalc, no physical device detection required)
- Minor bugs fixed
## 5.2.0-2 (2026-05-10)
- Fix startup loop on aarch64: drop s6-notifyoncheck wrapper so s6 supervises qbittorrent-nox directly (LSIO arm64 image has no notification-fd, causing EBADF restart loop)
## 5.2.0-1 (2026-05-10)
- Fix qbittorrent-nox path (/usr/bin → /app) after LSIO image update

View File

@@ -143,4 +143,4 @@ schema:
slug: qbittorrent
udev: true
url: https://github.com/alexbelgium/hassio-addons
version: "5.2.0-1"
version: "5.2.0-19"

View File

@@ -37,13 +37,18 @@ fi
# --- Launch qBittorrent ---
# Determine log output based on silent mode
QB_OUTPUT="/dev/stdout"
QB_OUTPUT="/proc/1/fd/1"
if bashio::config.true 'silent'; then
QB_OUTPUT="/dev/null"
fi
bashio::log.info "Starting qBittorrent..."
exec \
s6-notifyoncheck -d -n 300 -w 1000 -c "nc -z localhost ${WEBUI_PORT}" \
s6-setuidgid abc /app/qbittorrent-nox --webui-port="${WEBUI_PORT}" > "${QB_OUTPUT}"
if [ -f /etc/s6-overlay/s6-rc.d/svc-qbittorrent/notification-fd ]; then
exec \
s6-notifyoncheck -d -n 300 -w 1000 -c "nc -z localhost ${WEBUI_PORT}" \
s6-setuidgid abc /app/qbittorrent-nox --webui-port="${WEBUI_PORT}" > "${QB_OUTPUT}"
else
sleep 10
exec s6-setuidgid abc /app/qbittorrent-nox --webui-port="${WEBUI_PORT}" > "${QB_OUTPUT}"
fi

View File

@@ -535,9 +535,32 @@ _openvpn_down() {
pkill -f "openvpn --config ${config["ConfigFile"]}" || true
# Safety-net cleanup in case the --down callback was never invoked
_routing_del || true
# Safety-net: remove blackhole route for VPN server if postdown was never invoked
if [ -f "${OPENVPN_STATE_DIR}/server_ip" ]; then
local saved_ip
saved_ip=$(cat "${OPENVPN_STATE_DIR}/server_ip" 2>/dev/null || true)
if [ -n "${saved_ip}" ]; then
ip -4 route del blackhole "${saved_ip}/32" table "${config["Table"]}" 2>/dev/null || true
fi
rm -f "${OPENVPN_STATE_DIR}/server_ip"
fi
}
_openpvn_postup() {
_openvpn_postup() {
# Prevent recursive routing: add a blackhole route for the VPN server IP in
# table 1000. qBittorrent is bound to tun0, so its traffic is policy-routed
# into table 1000 (rule: from <tun_ip> -> table 1000). Without this, packets
# destined for the VPN server go through tun0, OpenVPN detects the loop and
# drops them. The blackhole makes qBittorrent's traffic to the server IP fail
# immediately (EHOSTUNREACH) instead of looping. OpenVPN itself is not bound
# to tun0, so its traffic uses the main table and reaches the server normally.
if [ -n "${trusted_ip:-}" ]; then
bashio::log.info "Adding blackhole route for VPN server ${trusted_ip} in table ${config["Table"]} to prevent recursive routing."
ip -4 route add blackhole "${trusted_ip}/32" table "${config["Table"]}" 2>/dev/null \
&& echo "${trusted_ip}" > "${OPENVPN_STATE_DIR}/server_ip" \
|| bashio::log.warning "Could not add blackhole route for VPN server ${trusted_ip}."
fi
# Add routing rules for VPN interface and DNS servers
_routing_add || return 1
# Add firewall rules for VPN interface (only when UPnP port mapping is enabled)
@@ -548,7 +571,19 @@ _openpvn_postup() {
_resolvconf "update" || return 1
}
_openpvn_postdown() {
_openvpn_postdown() {
# Remove blackhole route for VPN server (added in postup to prevent recursive routing)
local server_ip=""
if [ -n "${trusted_ip:-}" ]; then
server_ip="${trusted_ip}"
elif [ -f "${OPENVPN_STATE_DIR}/server_ip" ]; then
server_ip=$(cat "${OPENVPN_STATE_DIR}/server_ip" 2>/dev/null || true)
fi
if [ -n "${server_ip}" ]; then
ip -4 route del blackhole "${server_ip}/32" table "${config["Table"]}" 2>/dev/null || true
rm -f "${OPENVPN_STATE_DIR}/server_ip"
fi
# Update resolv.conf to remove VPN DNS servers
_resolvconf "reset" || true
# Remove routing rules for VPN interface and DNS servers
@@ -604,10 +639,10 @@ openvpn() {
bashio::log.info "OpenVPN on interface ${config["Interface"]} is down."
bashio::exit.ok 'OpenVPN stopped.'
elif [ "${mode}" = "postup" ]; then
_openpvn_postup
_openvpn_postup
bashio::exit.ok 'OpenVPN routes added.'
elif [ "${mode}" = "postdown" ]; then
_openpvn_postdown
_openvpn_postdown
bashio::exit.ok 'OpenVPN routes deleted.'
else
bashio::log.error "Invalid OpenVPN mode specified. Use 'up', 'down', 'postup', or 'postdown'."

View File

@@ -1,4 +1,5 @@
## &#9888; Open Issue : [🐛 Cloudcommander New Directory (opened 2026-03-19)](https://github.com/alexbelgium/hassio-addons/issues/2594) by [@pgitsov](https://github.com/pgitsov)
## &#9888; Open Issue : [🐛 [Qbittorent] qbittorrent-nox (opened 2026-05-09)](https://github.com/alexbelgium/hassio-addons/issues/2690) by [@BrainDeLook](https://github.com/BrainDeLook)
# Hass.io Add-ons: Tor with bridges
[![Donate][donation-badge]](https://www.buymeacoffee.com/alexbelgium)