Compare commits

..

16 Commits

Author SHA1 Message Date
copilot-swe-agent[bot]
427c09245c qbittorrent: fix OpenVPN stale-process loop and broken _routing_del
Agent-Logs-Url: https://github.com/alexbelgium/hassio-addons/sessions/9b5f5807-1537-4008-9933-f6a6b21ec5b4

Co-authored-by: alexbelgium <44178713+alexbelgium@users.noreply.github.com>
2026-05-12 12:16:46 +00:00
copilot-swe-agent[bot]
43b1b7c916 Initial plan 2026-05-12 11:57:54 +00:00
github-actions
f59266ad57 GitHub bot: changelog [nobuild] 2026-05-12 10:23:59 +00:00
Alexandre
3b643c5613 Update config.yaml 2026-05-12 12:19:21 +02:00
Alexandre
a247c0c782 Merge pull request #2706 from alexbelgium/copilot/fix-qbittorrent-wireguard-connection
qbittorrent: Fix WireGuard "RTNETLINK answers: File exists" crash loop on S6 service restart
2026-05-12 08:52:00 +02:00
copilot-swe-agent[bot]
cf584b9c07 Fix WireGuard RTNETLINK File exists crash loop on S6 service restart
Agent-Logs-Url: https://github.com/alexbelgium/hassio-addons/sessions/caef8dfd-90cd-45ac-a539-6049bb90fd9b

Co-authored-by: alexbelgium <44178713+alexbelgium@users.noreply.github.com>
2026-05-12 06:32:12 +00:00
copilot-swe-agent[bot]
58a042996c Initial plan 2026-05-12 06:28:09 +00:00
github-actions
9a0c7cea5f GitHub bot: changelog [nobuild] 2026-05-11 18:48:18 +00:00
Alexandre
15d14ca9b0 Merge pull request #2705 from ToledoEM/manyfold
Update version Manyfold3D to 0.139.3
2026-05-11 20:46:13 +02:00
Enrique
098f04781b Update version to 0.139.3 in config.yaml
version bump of manyfold
2026-05-11 19:26:52 +01:00
github-actions
575ff2264f Github bot : issues linked to readme 2026-05-11 16:09:06 +00:00
Alexandre
9e6ecedbc1 Merge pull request #2702 from alexbelgium/claude/fix-qbittorrent-arm64-startup-zFYXB
Fix qbittorrent startup loop on aarch64: drop s6-notifyoncheck
2026-05-11 07:19:43 +02:00
Claude
f5328b6d66 Fix aarch64 startup loop: /proc/1/fd/1 + notification-fd guard
Two independent failure modes can cause the restart loop on arm64:

1. /dev/stdout may be inaccessible in some ARM container runtimes; replaced
   with /proc/1/fd/1 which LSIO images already use for direct container stdout.

2. s6-notifyoncheck writes to fd 3 on check success, but s6-rc only opens
   that fd when notification-fd exists in the service directory. LSIO arm64
   images ship svc-qbittorrent without it, so s6-notifyoncheck exits with
   EBADF and s6 restarts the service in a loop. Guard with a file check and
   fall back to exec'ing qbittorrent-nox directly when the file is absent.

https://claude.ai/code/session_01F16ThtZyfXj6ZKFPkrSAAq
2026-05-11 05:19:13 +00:00
Claude
862097d6bd Fix aarch64 startup loop: use /proc/1/fd/1 instead of /dev/stdout
/dev/stdout resolves via /proc/self/fd/1 and can be inaccessible in some
ARM container runtimes, causing the exec redirect to fail and s6 to restart
the service in a loop. /proc/1/fd/1 is the path LSIO images already use
for direct container stdout (see nginx silent-mode handling) and is reliable
across architectures.

https://claude.ai/code/session_01F16ThtZyfXj6ZKFPkrSAAq
2026-05-11 05:17:32 +00:00
Claude
e5048aa378 Fix aarch64 startup loop: use s6-notifyoncheck only when notification-fd exists
s6-rc opens fd 3 for a longrun service only when a notification-fd file is
present in the service directory. The LSIO aarch64 image ships svc-qbittorrent
without that file, so fd 3 is never opened. s6-notifyoncheck exits with EBADF
after its readiness check passes, s6 treats the supervised process as dead and
immediately restarts it — producing the infinite "Starting qBittorrent..." loop.

Check for the notification-fd file at runtime: use the full s6-notifyoncheck
path when it is present (amd64, preserving existing behaviour), and fall back
to exec'ing qbittorrent-nox directly when it is absent (aarch64).

https://claude.ai/code/session_01F16ThtZyfXj6ZKFPkrSAAq
2026-05-11 05:16:13 +00:00
Claude
8bdb3897da Fix qbittorrent startup loop on aarch64: drop s6-notifyoncheck
s6-notifyoncheck writes to fd 3 when its readiness check passes, but
the LSIO aarch64 image's svc-qbittorrent service has no notification-fd
file so s6-rc never opens fd 3. s6-notifyoncheck exits with EBADF, s6
sees the supervised process die and immediately restarts it, producing
the infinite "Starting qBittorrent..." loop seen on odroid-c2 and other
aarch64 boards.

Drop s6-notifyoncheck entirely and exec qbittorrent-nox directly under
s6-setuidgid so s6 supervises the real process. Silent mode is handled
by redirecting the shell's fds before exec rather than passing a
/dev/stdout path (avoids a separate class of ARM container fd issues).

https://claude.ai/code/session_01F16ThtZyfXj6ZKFPkrSAAq
2026-05-10 16:30:23 +00:00
7 changed files with 80 additions and 12 deletions

View File

@@ -1,3 +1,5 @@
## 0.139.3 (11-05-2026)
- Minor bugs fixed
## 0.138.0 (24-04-2026)
- Minor bugs fixed
## 0.137.0 (13-04-2026)

View File

@@ -1,7 +1,7 @@
name: "Manyfold"
slug: manyfold
description: "Manyfold 3D model manager as a Home Assistant add-on, using the upstream image with configurable library/index paths."
version: "0.138.0"
version: "0.139.3"
url: "https://github.com/alexbelgium/hassio-addons/tree/master/manyfold"
image: ghcr.io/alexbelgium/manyfold-{arch}
arch:

View File

@@ -1,3 +1,15 @@
## 5.2.0-7 (12-05-2026)
- Fix OpenVPN stale-process crash loop on S6 service restart: kill any existing OpenVPN daemon and clean up stale interface/routing state before re-establishing the tunnel (same class of fix as WireGuard 5.2.0-3)
- Fix broken routing rule cleanup: `_routing_del` was deleting rules with `from all`/`to all` wildcard which never matched the specific `from IP`/`to IP` rules added by `_routing_add`, leaving stale routing rules after VPN teardown and causing DNS resolution failures when OpenVPN tried to reconnect
## 5.2.0-6 (12-05-2026)
- Minor bugs fixed
## 5.2.0-3 (2026-05-12)
- Fix WireGuard "RTNETLINK answers: File exists" crash loop: clean up stale interface and routing rules before re-establishing the tunnel on S6 service restart
## 5.2.0-2 (2026-05-10)
- Fix startup loop on aarch64: drop s6-notifyoncheck wrapper so s6 supervises qbittorrent-nox directly (LSIO arm64 image has no notification-fd, causing EBADF restart loop)
## 5.2.0-1 (2026-05-10)
- Fix qbittorrent-nox path (/usr/bin → /app) after LSIO image update

View File

@@ -143,4 +143,4 @@ schema:
slug: qbittorrent
udev: true
url: https://github.com/alexbelgium/hassio-addons
version: "5.2.0-1"
version: "5.2.0-7"

View File

@@ -37,13 +37,17 @@ fi
# --- Launch qBittorrent ---
# Determine log output based on silent mode
QB_OUTPUT="/dev/stdout"
QB_OUTPUT="/proc/1/fd/1"
if bashio::config.true 'silent'; then
QB_OUTPUT="/dev/null"
fi
bashio::log.info "Starting qBittorrent..."
exec \
s6-notifyoncheck -d -n 300 -w 1000 -c "nc -z localhost ${WEBUI_PORT}" \
s6-setuidgid abc /app/qbittorrent-nox --webui-port="${WEBUI_PORT}" > "${QB_OUTPUT}"
if [ -f /etc/s6-overlay/s6-rc.d/svc-qbittorrent/notification-fd ]; then
exec \
s6-notifyoncheck -d -n 300 -w 1000 -c "nc -z localhost ${WEBUI_PORT}" \
s6-setuidgid abc /app/qbittorrent-nox --webui-port="${WEBUI_PORT}" > "${QB_OUTPUT}"
else
exec s6-setuidgid abc /app/qbittorrent-nox --webui-port="${WEBUI_PORT}" > "${QB_OUTPUT}"
fi

View File

@@ -192,13 +192,36 @@ _routing_add() {
_routing_del() {
bashio::log.info "Removing routing rules for VPN interface ${config["Interface"]}..."
local table="${config["Table"]}"
local line prio rest
while _cmd "ip -4 rule del priority 1 from all table ${config["Table"]} 2>/dev/null"; do :; done
while _cmd "ip -4 rule del priority 1 to all table ${config["Table"]} 2>/dev/null"; do :; done
while _cmd "ip -4 route del default dev ${config["Interface"]} table ${config["Table"]} 2>/dev/null"; do :; done
while _cmd "ip -6 rule del priority 1 from all table ${config["Table"]} 2>/dev/null"; do :; done
while _cmd "ip -6 rule del priority 1 to all table ${config["Table"]} 2>/dev/null"; do :; done
while _cmd "ip -6 route del default dev ${config["Interface"]} table ${config["Table"]} 2>/dev/null"; do :; done
# Remove all IPv4 policy rules pointing to our custom routing table.
# We must parse `ip rule list` and delete each matching rule individually,
# because the rules were added with specific from/to selectors (e.g.
# "from 10.8.0.2" or "to 8.8.8.8") — not the "from all" wildcard that
# the old code tried to delete, which never matched anything.
while IFS= read -r line; do
[[ "${line}" =~ ^[[:space:]]*([0-9]+):[[:space:]]+(.*lookup[[:space:]]+${table}.*)$ ]] || continue
prio="${BASH_REMATCH[1]}"
rest="${BASH_REMATCH[2]}"
# shellcheck disable=SC2206 — word-split is intentional: ip needs individual tokens
local -a rule_args=( ${rest} )
ip -4 rule del prio "${prio}" "${rule_args[@]}" 2>/dev/null || true
done < <(ip -4 rule list 2>/dev/null)
# Same for IPv6
while IFS= read -r line; do
[[ "${line}" =~ ^[[:space:]]*([0-9]+):[[:space:]]+(.*lookup[[:space:]]+${table}.*)$ ]] || continue
prio="${BASH_REMATCH[1]}"
rest="${BASH_REMATCH[2]}"
# shellcheck disable=SC2206 — word-split is intentional: ip needs individual tokens
local -a rule_args=( ${rest} )
ip -6 rule del prio "${prio}" "${rule_args[@]}" 2>/dev/null || true
done < <(ip -6 rule list 2>/dev/null)
# Flush all routes in our custom table
ip -4 route flush table "${table}" 2>/dev/null || true
ip -6 route flush table "${table}" 2>/dev/null || true
}
# --- Firewall Specific Functions ---
@@ -279,6 +302,16 @@ _wireguard_up() {
fi
done
# Clean up any leftover state from a previous run (e.g., after an S6 service restart).
# Without this, `ip link add` and `ip rule add` fail with "RTNETLINK answers: File exists"
# when the svc-qbittorrent service is restarted while the WireGuard interface is still up.
if ip link show "${config["Interface"]}" > /dev/null 2>&1; then
bashio::log.info "WireGuard interface ${config["Interface"]} already exists. Cleaning up before re-establishing connection."
ip link set "${config["Interface"]}" down 2>/dev/null || true
ip link del "${config["Interface"]}" 2>/dev/null || true
fi
_routing_del 2>/dev/null || true
_cmd "ip link add ${config["Interface"]} type wireguard" || return 1
mapfile -d ',' -t local_ips < <(echo "${config["Address"]}" | tr -d ' ')
@@ -490,6 +523,22 @@ _openvpn_up() {
bashio::log.warning "This routing table will be used for traffic from the VPN interface and to the configured DNS servers."
bashio::log.warning "Qbittorrent bittorrent client shall be set to use the VPN interface ${config["Interface"]} only."
# Clean up any leftover state from a previous run (e.g., after an S6 service restart).
# Without this, a second OpenVPN daemon starts while the first is still running, leaving
# stale routing rules that cause DNS resolution failures during reconnect — the same class
# of bug that was fixed for WireGuard in 5.2.0-3.
if pgrep -f "openvpn --config ${config["ConfigFile"]}" > /dev/null 2>&1; then
bashio::log.info "Previous OpenVPN process found. Stopping it before re-establishing connection."
pkill -TERM -f "openvpn --config ${config["ConfigFile"]}" 2>/dev/null || true
sleep 2
fi
if ip link show "${config["Interface"]}" > /dev/null 2>&1; then
bashio::log.info "OpenVPN interface ${config["Interface"]} already exists. Cleaning up before re-establishing connection."
ip link set "${config["Interface"]}" down 2>/dev/null || true
fi
_routing_del 2>/dev/null || true
_resolvconf "reset" 2>/dev/null || true
# Register this script as OpenVPN up/down handlers to manage routing
echo '#!/bin/bash' > ${config["PostUpScript"]}
echo "${config["MySelf"]} openvpn postup" >> ${config["PostUpScript"]}

View File

@@ -1,4 +1,5 @@
## &#9888; Open Issue : [🐛 Cloudcommander New Directory (opened 2026-03-19)](https://github.com/alexbelgium/hassio-addons/issues/2594) by [@pgitsov](https://github.com/pgitsov)
## &#9888; Open Issue : [🐛 [Qbittorent] qbittorrent-nox (opened 2026-05-09)](https://github.com/alexbelgium/hassio-addons/issues/2690) by [@BrainDeLook](https://github.com/BrainDeLook)
# Hass.io Add-ons: Tor with bridges
[![Donate][donation-badge]](https://www.buymeacoffee.com/alexbelgium)