Compare commits

...

5 Commits

Author SHA1 Message Date
alexbelgium
bae169871a docs(skill): pin the upstream digest for revert comparisons, and note layer whiteouts
Both raised in review of #3028: with build_from :latest a revert only
discriminates when both builds resolve the same upstream image, and plain tar
does not process OCI whiteouts when reconstructing a rootfs from layers.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-30 08:30:33 +02:00
alexbelgium
979f7dbe5c docs(skill): record that a clean local reproduction does not outrank a production report
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-30 08:24:40 +02:00
alexbelgium
1d86e79dce revert(filebrowser_quantum): drop the ingress window.open filter pending download report
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-30 08:18:20 +02:00
Alexandre
331af4bcc9 fix(filebrowser_quantum): navigate in place instead of opening a new tab under ingress (#3026)
The tool views (Tools -> File Size Analyzer, Duplicate Finder, the file list
panel) always pass showLimitedOptions to the context menu, and the context
menu's openParentFolder() hands that same flag to goToItem() as its newTab
argument. The parent folder is therefore opened with
window.open(<absolute url>, '_blank'). Behind Home Assistant ingress that
popup lands on the raw /api/hassio_ingress/<token>/ URL with no Home
Assistant frontend around it to keep the ingress session alive, so the new
tab answers 401 instead of showing the folder.

The ingress vhost now injects the same window.open shim the komga add-on
uses, scoped to the two SPA route prefixes goToItem() builds ('files/' and
'public/share/'), so download and preview popups keep their own tab.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
2026-08-30 07:59:04 +02:00
github-actions[bot]
141ffe9075 Update stargazer map & cache 2026-08-30 00:53:58 +00:00
5 changed files with 87 additions and 1 deletions

View File

@@ -58,3 +58,60 @@ Once the rebuilt add-on is running, re-run the measurement that motivated the wo
cannot be self-verified — a service that reads its environment only at start makes an env-var fix
unproven until the add-on restarts, which needs the user or `ha-cli` with their agreement. If you
cannot restart, the change is **Assumed**, not Verified, and must be reported that way.
## A local reproduction that passes does not outrank a user's production report
PR #3026 added an nginx `sub_filter` to the `filebrowser_quantum` ingress vhost. After it merged,
the user reported that Download had stopped working — the file opened inline instead. Every check
run against the change came back clean:
- the shipped bundle's Download action builds an `<a href>` and clicks it, and never calls
`window.open`, which is all the injected shim overrides;
- the shim's own predicate, evaluated live in the running app, returned false for the download
URL, the `inline=true` raw URL and the public-share download URL;
- the download response through the vhost was **byte-identical** with and without the `sub_filter`
(`Content-Disposition: attachment` intact, `Content-Length` unchanged), for `text/plain` and for
the `text/html` case the filter actually scans;
- upstream's frontend download code is unchanged from v1.5.0-stable to v1.5.4-stable, and Home
Assistant's ingress iframe carries no `sandbox` attribute (`ha-panel-app.ts`), so downloads are
not sandbox-blocked either.
None of that reproduced the failure, and none of it explained the one fact that mattered: the user
saw it fail under ingress and work on the add-on's direct port, and the `sub_filter` was the only
ingress-side change in that update. **Revert first and keep investigating.**
A revert can also discriminate — if the symptom survives it, the cause was the concurrent upstream
bump rather than the diff — but only if **both builds resolve the same upstream image**. With
`build_from: <image>:latest` they need not: `latest` can move between the two rebuilds, and then
the comparison proves nothing. Resolve the tag to a digest and record it before and after, or pin
`build_from` to that digest for the duration of the experiment:
```bash
T=$(curl -s "https://auth.docker.io/token?service=registry.docker.io&scope=repository:<repo>:pull" | jq -r .token)
curl -s -H "Authorization: Bearer $T" \
-H "Accept: application/vnd.oci.image.index.v1+json" \
"https://registry-1.docker.io/v2/<repo>/manifests/latest" \
| jq -r '.manifests[] | select(.platform.architecture=="amd64" and .platform.os=="linux") | .digest'
```
For the case above both builds resolved `gtstef/filebrowser:latest` amd64 to
`sha256:e549e1a9b5de573c276f7be67444841559e3f89cbc664a2f926968453d069436` (v1.5.4-stable, created
2026-08-29T14:19:56Z), so that comparison was controlled — but it was luck, not design.
Worth building next time, because it took most of the session and is reusable: a reproduction rig
made **out of the published image's own layers**, with no dockerd. Pull the manifest and blobs from
the registry with `curl` + `jq`, untar them in order, then run the extracted binary through the
image's own musl loader (`root/lib/ld-musl-x86_64.so.1 ./filebrowser`) with the real `http/dist`
next to it. Plain `tar` does not interpret whiteouts, so a file a later layer deletes
(`.wh.<name>`) or a directory it marks opaque (`.wh..wh..opq`) survives into the reconstructed
rootfs; check with `tar tzf <layer> | grep '\.wh\.'` and reach for an OCI-aware unpacker if any
turn up. (There were none in `gtstef/filebrowser:latest` — all eleven layers, 0 whiteout entries —
so that rig was faithful.) Put the add-on's rendered `ingress.conf` in front of it, and a second nginx server in
front of that to strip the `/api/hassio_ingress/<token>` prefix the way Supervisor does. That gets
the real frontend, the real backend and the real vhost under a browser — everything except
Supervisor itself.
**`build_from: <image>:latest` means every merge ships an upstream version bump too.** Record which
upstream version each add-on image was built from — the registry config blob's `created` timestamp,
the resolved manifest digest, and the binary's version string — before attributing a regression to
the diff.

View File

@@ -273,6 +273,7 @@ Gajalshankar,India,
Gangol,,2026-08-10
Garak1980,,2026-08-10
GaryOG,,2026-08-10
GentryChe,,2026-08-30
Germaenace,,2026-08-10
Getrio,Italy,
Ghost-Sam1222,,2026-08-10
@@ -385,6 +386,7 @@ JosephBlock,United States,
Julian1701,,2026-08-10
JulienFloris,Netherlands,
JuraLadanov,,2026-08-10
Jutsch,,2026-08-30
K0stIa,,2026-08-10
KRC604,,2026-08-10
KairuByte,,2026-08-10
@@ -441,6 +443,7 @@ Lizzardis,,2026-08-10
LoginByCall,,2026-08-10
Lolekpolek,,2026-08-10
LonelySoul7X,,2026-08-10
Loong-He,China,2026-08-30
Lorsel,Italy,
Luca2165801154,,2026-08-10
Lucius-Waverly,,2026-08-16
@@ -990,6 +993,7 @@ berkovich98,,2026-08-10
bertrand-f,,2026-08-10
bes-r,Netherlands,
bestnub,Germany,
betechyou,,2026-08-30
beyercenter,,2026-08-10
bezigebever,,2026-08-10
bggsolar,Germany,
@@ -1225,6 +1229,7 @@ denisgolius,Ukraine,
dennisjonda,Germany,
dennisvandalen,Netherlands,
denvernbd,Russian Federation,2026-08-10
der-berni,Germany,2026-08-30
derailius,,2026-08-10
dethpickle,United States,
dev4jam,Australia,
@@ -1522,6 +1527,7 @@ hreikin,United Kingdom,
hsiguy,,2026-08-10
huangyixinv,,2026-08-10
hubikj,,2026-08-10
hufforguk,,2026-08-30
hugobloem,United Kingdom,
hujiayi0126,,2026-08-10
hunterlong,United States,
@@ -1661,6 +1667,7 @@ joshcliffejones,United Kingdom,
joshmeads,Canada,
josiah-eichelman,,2026-08-10
jpaulomt,,
jpeisach,United States,2026-08-30
jpmaldonado,,2026-08-10
jpoll962,,2026-08-10
jpombas,Portugal,
@@ -1831,6 +1838,7 @@ mProwler,United States,
mStrangers,,2026-08-10
mabt,,2026-08-10
macedobernardo,,2026-08-10
machineGnu,,2026-08-30
madjetey,,2026-08-10
maggle-swim,,2026-08-10
malachitgruen,Germany,
@@ -1840,6 +1848,7 @@ manu7691,United States,
manugratx,,2026-08-10
mapeje,Sweden,
maphouse,Canada,
marat-365,,2026-08-30
maratbakirov,,2026-08-10
marcetad,,2026-08-10
marcjay,United Kingdom,
@@ -1849,6 +1858,7 @@ marcschraepler,Austria,
marcusrbrown,,2026-08-10
mareklab,,2026-08-10
marevers,Germany,
marialaranjo,,2026-08-30
marian-paun,Romania,
mariusvslprts,Germany,
mark-219,United States,2026-08-16
@@ -2173,6 +2183,7 @@ pwitte,,2026-08-10
pxshh,,2026-08-10
pynbbz,,2026-08-10
pyrech,France,
pysj,,2026-08-30
pziezio,Poland,
pzkpfw6,,2026-08-10
qadk,,2026-08-10
@@ -2196,6 +2207,7 @@ rascasseuk,,2026-08-10
raul811,,2026-08-10
raulpetruta,Romania,
rawpie2,,2026-08-10
raymand211092,Cuba,2026-08-30
raytedjaja,,2026-08-10
rbalaev,,2026-08-10
rbaron,,2026-08-10
@@ -2211,6 +2223,7 @@ reggiano,,2026-08-10
reid,United States,
reinvanhaaren,Netherlands,
remb0,Netherlands,
renatoptr,,2026-08-30
renejr63,,2026-08-10
resomi,,2026-08-10
retpolanne,Brazil,
1 username country last_checked
273 Gangol 2026-08-10
274 Garak1980 2026-08-10
275 GaryOG 2026-08-10
276 GentryChe 2026-08-30
277 Germaenace 2026-08-10
278 Getrio Italy
279 Ghost-Sam1222 2026-08-10
386 Julian1701 2026-08-10
387 JulienFloris Netherlands
388 JuraLadanov 2026-08-10
389 Jutsch 2026-08-30
390 K0stIa 2026-08-10
391 KRC604 2026-08-10
392 KairuByte 2026-08-10
443 LoginByCall 2026-08-10
444 Lolekpolek 2026-08-10
445 LonelySoul7X 2026-08-10
446 Loong-He China 2026-08-30
447 Lorsel Italy
448 Luca2165801154 2026-08-10
449 Lucius-Waverly 2026-08-16
993 bertrand-f 2026-08-10
994 bes-r Netherlands
995 bestnub Germany
996 betechyou 2026-08-30
997 beyercenter 2026-08-10
998 bezigebever 2026-08-10
999 bggsolar Germany
1229 dennisjonda Germany
1230 dennisvandalen Netherlands
1231 denvernbd Russian Federation 2026-08-10
1232 der-berni Germany 2026-08-30
1233 derailius 2026-08-10
1234 dethpickle United States
1235 dev4jam Australia
1527 hsiguy 2026-08-10
1528 huangyixinv 2026-08-10
1529 hubikj 2026-08-10
1530 hufforguk 2026-08-30
1531 hugobloem United Kingdom
1532 hujiayi0126 2026-08-10
1533 hunterlong United States
1667 joshmeads Canada
1668 josiah-eichelman 2026-08-10
1669 jpaulomt
1670 jpeisach United States 2026-08-30
1671 jpmaldonado 2026-08-10
1672 jpoll962 2026-08-10
1673 jpombas Portugal
1838 mStrangers 2026-08-10
1839 mabt 2026-08-10
1840 macedobernardo 2026-08-10
1841 machineGnu 2026-08-30
1842 madjetey 2026-08-10
1843 maggle-swim 2026-08-10
1844 malachitgruen Germany
1848 manugratx 2026-08-10
1849 mapeje Sweden
1850 maphouse Canada
1851 marat-365 2026-08-30
1852 maratbakirov 2026-08-10
1853 marcetad 2026-08-10
1854 marcjay United Kingdom
1858 marcusrbrown 2026-08-10
1859 mareklab 2026-08-10
1860 marevers Germany
1861 marialaranjo 2026-08-30
1862 marian-paun Romania
1863 mariusvslprts Germany
1864 mark-219 United States 2026-08-16
2183 pxshh 2026-08-10
2184 pynbbz 2026-08-10
2185 pyrech France
2186 pysj 2026-08-30
2187 pziezio Poland
2188 pzkpfw6 2026-08-10
2189 qadk 2026-08-10
2207 raul811 2026-08-10
2208 raulpetruta Romania
2209 rawpie2 2026-08-10
2210 raymand211092 Cuba 2026-08-30
2211 raytedjaja 2026-08-10
2212 rbalaev 2026-08-10
2213 rbaron 2026-08-10
2223 reid United States
2224 reinvanhaaren Netherlands
2225 remb0 Netherlands
2226 renatoptr 2026-08-30
2227 renejr63 2026-08-10
2228 resomi 2026-08-10
2229 retpolanne Brazil

Binary file not shown.

Before

Width:  |  Height:  |  Size: 68 KiB

After

Width:  |  Height:  |  Size: 404 KiB

View File

@@ -1,4 +1,20 @@
## 1.5.3.2 (2026-08-30)
- Revert the 1.5.3.1 ingress filter while a report of broken downloads is
investigated. "Open parent directory" in the tool views opens a new tab
again, as it did up to 1.5.3.
## 1.5.3.1 (2026-08-29)
- Fix "open parent directory" in Tools -> File Size Analyzer under Home
Assistant ingress. FileBrowser opened the parent folder in a new tab, which
lands on the raw ingress URL with no Home Assistant frontend around it to
keep the ingress session alive, so the new tab answered 401 instead of
showing the folder. The ingress vhost now turns that popup into a navigation
of the panel itself. The same fix covers the other tool views and the "go to
item" action on search results, which open a new tab the same way. Download
and preview popups, links pointing out of the add-on, and direct access on
port 8071 are unchanged.
## 1.5.3 (2026-08-29)
- Update to latest version from gtsteffaniak/filebrowser (changelog : https://github.com/gtsteffaniak/filebrowser/releases)

View File

@@ -118,4 +118,4 @@ schema:
slug: filebrowser_quantum
udev: true
url: https://github.com/alexbelgium/hassio-addons
version: "1.5.3"
version: "1.5.3.2"